Repository navigation
feat(validation): use SDK exports for OCI client and model resolution and validation - #557
Merged
dustin-sale merged 1 commit intoNov 12, 2026
Conversation
gebhardtr
marked this pull request as ready for review
November 11, 2026 23:10
gebhardtr
requested review from
AlaaShaker,
dustin-sale,
irfan-ahmed,
krisrice and
robander
as code owners
November 11, 2026 23:10
dustin-sale
approved these changes
Nov 12, 2026
dustin-sale
left a comment
Contributor
There was a problem hiding this comment.
Review by @dustin-sale via Codex.
Requested changes
No blocking changes requested.
Additional review notes
None.
Validation
Cloud tests passed: 302 tests, 94.26% branch-inclusive coverage.
Repository lint, Cloud lock/build/install checks, and coverage aggregation passed.
An additional compatibility probe verified all 323 exported clients and 16,327
exported model classes in OCI SDK 2.185.1. No live OCI calls were executed.
No inline comments.
Resolve client and model names through the installed OCI SDK's service exports and model mappings. Validate operation and explicit model identities before constructors, and reuse validated objects for error hints instead of resolving rejected input again. Signed-off-by: Richard Gebhardt <richard.gebhardt@oracle.com>
gebhardtr
force-pushed
the
rigebha/cloud-sdk-export-resolution
branch
from
November 12, 2026 19:06
f377608 to
2b83003
Compare
dustin-sale
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve client and model names through the installed OCI SDK's service exports and model mappings. Validate operation and explicit model identities before constructors, and reuse validated objects for error hints instead of resolving rejected input again.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: